Re: Proposal - Allow extensions to set a Plan Identifier
Andrei Lepikhov <lepihov@gmail.com>
From: Andrei Lepikhov <lepihov@gmail.com>
To: Sami Imseih <samimseih@gmail.com>
Cc: Lukas Fittl <lukas@fittl.com>,
Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>,
Michael Paquier <michael@paquier.xyz>
Date: 2025-03-25T09:42:57Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Allow plugins to set a 64-bit plan identifier in PlannedStmt
- 2a0cd38da5cc 18.0 landed
On 3/25/25 00:47, Sami Imseih wrote: > I know it was mentioned above by both Michael and Andrei that > AppendJumble should not be exposed. I am not sure I agree with > that. I think it should be exposed, along with > JUMBLE_FIELD, JUMBLE_FIELD_SINGLE and JUMBLE_STRING > and _jumbleList. It would be helpful if you could provide an example to support the reasoning behind exposing this stuff. I assume you want to influence the logic of jumbling, correct? If that’s the case, it might be beneficial to add a callback to the JumbleState that is triggered during each node jumbling attempt. This could facilitate moving clocations code and data into pg_stat_statements and give developers the opportunity to influence the jumbling process, adding extra meaning to their hashes. One reason this might be necessary is that generating the same hash for both a Param node and a Const node could lead to a more generalized hash, allowing us to group more queries under the same value. -- regards, Andrei Lepikhov