Re: pgsql: Use data directory inode number, not port, to select SysV resour
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-09-08T21:54:12Z
Lists: pgsql-hackers
On 9/6/19 3:51 PM, Andrew Dunstan wrote: > On 9/6/19 2:42 PM, Tom Lane wrote: >> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes: >>> Given your stated intention, I think the simplest way to get it is just >>> this, without worrying about what the perl modules might do: >>> -if ($@) >>> +if ($@ || $windows_os) >> WFM, do you want to push that? >> >> > > done. > > [redirected to -hackers] I'm going to disable this test (src/test/recovery/t/017_shm.pl) on Windows on the back branches too unless there's a violent objection. The reason is that the script runs "postgres --single" and that fails on Windows when run by an administrative account. We've carefully enabled postgres and its tests to run safely under an admin account. I discovered this as part of my myss2 testing. cheers andrew
Commits
-
Always skip recovery SysV shared memory tests on Windows
- ef52d39bdf62 9.6.16 landed
- d0a98e1ae26c 10.11 landed
- b97a345d9691 11.6 landed
- 7d49803259de 12.0 landed
- 8e5ce1c3f837 13.0 landed
-
Use data directory inode number, not port, to select SysV resource keys.
- 7de19fbc0b1a 13.0 cited