Re: WIP Incremental JSON Parser

On 2024-01-22 Mo 21:02, Andrew Dunstan wrote:
>
> On 2024-01-22 Mo 18:01, Andrew Dunstan wrote:
>>
>> On 2024-01-22 Mo 14:16, Andrew Dunstan wrote:
>>>
>>> On 2024-01-22 Mo 01:29, Peter Smith wrote:
>>>> 2024-01 Commitfest.
>>>>
>>>> Hi, This patch has a CF status of "Needs Review" [1], but it seems
>>>> there were CFbot test failures last time it was run [2]. Please have a
>>>> look and post an updated version if necessary.
>>>
>>>
>>> Thanks.
>>>
>>> Let's see if the attached does better.
>>
>>
>>
>> This time for sure! (Watch me pull a rabbit out of my hat!)
>>
>>
>> It turns out that NO_TEMP_INSTALL=1 can do ugly things, so I removed 
>> it, and I think the test will now pass.
>>
>>
>>
>
> Fixed one problem but there are some others. I'm hoping this will 
> satisfy the cfbot.
>
>
>

The cfbot reports an error on a 32 bit build 
<https://api.cirrus-ci.com/v1/artifact/task/6055909135220736/testrun/build-32/testrun/pg_combinebackup/003_timeline/log/regress_log_003_timeline>:

# Running: pg_basebackup -D /tmp/cirrus-ci-build/build-32/testrun/pg_combinebackup/003_timeline/data/t_003_timeline_node1_data/backup/backup2 --no-sync -cfast --incremental /tmp/cirrus-ci-build/build-32/testrun/pg_combinebackup/003_timeline/data/t_003_timeline_node1_data/backup/backup1/backup_manifest
pg_basebackup: error: could not upload manifest: ERROR:  could not parse backup manifest: file size is not an integer
pg_basebackup: removing data directory "/tmp/cirrus-ci-build/build-32/testrun/pg_combinebackup/003_timeline/data/t_003_timeline_node1_data/backup/backup2"
[02:41:07.830](0.073s) not ok 2 - incremental backup from node1
[02:41:07.830](0.000s) #   Failed test 'incremental backup from node1'

I have set up a Debian 12 EC2 instance following the recipe at 
<https://raw.githubusercontent.com/anarazel/pg-vm-images/main/scripts/linux_debian_install_deps.sh>, 
and ran what I think are the same tests dozens of times, but the failure 
did not reappear in my setup. Unfortunately, the test doesn't show the 
failing manifest or log the failing field, so trying to divine what 
happened here is more than difficult.

Not sure how to address this.


cheers


andrew


--
Andrew Dunstan
EDB:https://www.enterprisedb.com