Horton

Re: Handle infinite recursion in logical replication setup

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, "Jonathan S. Katz" <jkatz@postgresql.org>
Date: 2023-08-16T13:50:09Z
Lists: pgsql-hackers 
On 09.08.23 04:50, Peter Smith wrote:
> On Tue, Aug 8, 2023 at 6:52 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> On Tue, Aug 8, 2023 at 1:50 PM Peter Eisentraut <peter@eisentraut.org> wrote:
>>>
>>> This patch added the following error message:
>>>
>>> errdetail_plural("Subscribed publication %s is subscribing to other
>>> publications.",
>>> "Subscribed publications %s are subscribing to other publications.",
>>> list_length(publist), pubnames->data),
>>>
>>> But in PostgreSQL, a publication cannot subscribe to a publication, so
>>> this is not giving accurate information.  Apparently, what it is trying
>>> to say is that
>>>
>>> The subscription that you are creating subscribes to publications that
>>> contain tables that are written to by other subscriptions.
>>>
>>> Can we get to a more accurate wording like this?
>>>
>>
>> +1 for changing the message as per your suggestion.
>>
> 
> PSA a patch to change this message text. The message now has wording
> similar to the suggestion.

committed, thanks

Commits

  1. Improved CREATE SUBSCRIPTION message for clarity

  2. Fix the test case introduced by commit 8756930190.

  3. Raise a warning if there is a possibility of data from multiple origins.

  4. Add wait_for_subscription_sync for TAP tests.

  5. Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.

  6. Allow users to skip logical replication of data having origin.

  7. Improve two comments related to a boolean DefElem's value

  8. doc: Fix man page whitespace issues