Horton
Menu

Re: Improve verification of recovery_target_timeline GUC.

David Steele <david@pgbackrest.org>

View thread
From: David Steele <david@pgbackrest.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2025-01-24T13:36:45Z
Lists: pgsql-hackers

Attachments

On 1/24/25 01:44, Michael Paquier wrote:
> On Thu, Jan 23, 2025 at 02:53:39PM +0000, David Steele wrote:
> 
>> I discovered this while testing on Postgres versions < 12 where
>> The tests are probably excessive but I needed something to show that the
>> verification works as expected.
> 
> Even with your patch, specifying an incorrect name results in a
> complaint about a timeline of 0.  Wouldn't it be better to strengthen
> the parsing in check_recovery_target_timeline() and/or the error
> message reported?

I attached the wrong patch. Oops!

Regards,
-David

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix constant in error message for recovery_target_timeline

  2. Improve checks for GUC recovery_target_timeline