Re: [BUG FIX]: invalid meson version detection

On 14/08/2024 17:02, Sergey Solovev wrote:
> I looked at meson.build file at found an incorrectly used function to
> 
> determine postgres version.
> 
> 
>   > if pg_version.endswith('devel')
>   >   pg_version_arr = [pg_version.split('devel')[0], '0']
> 
> 
> There should be `pg_version.contains('devel')`, not `endswith`. Like this:
> 
> -if pg_version.endswith('devel')
> +if pg_version.contains('devel')

I believe it's correct as it is. With "beta" and "rc" version, the 
version strings look like "17beta1" or "16rc2", i.e. there's a number at 
the end of the string. But the "devel" version strings never have that, 
e.g. "17devel" or "18devel".

See also src/tools/version_stamp.pl

-- 
Heikki Linnakangas
Neon (https://neon.tech)