Re: Reorganize GUC structs
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
Heikki Linnakangas <hlinnaka@iki.fi>, John Naylor <johncnaylorls@gmail.com>
Date: 2025-11-07T15:44:40Z
Lists: pgsql-hackers
On 07.11.25 10:38, Álvaro Herrera wrote:
> On 2025-Nov-07, Peter Eisentraut wrote:
>
>> @@ -3135,14 +3135,14 @@ parse_and_validate_value(const struct config_generic *record,
>> char *hintmsg;
>>
>> hintmsg = config_enum_get_options(conf,
>> - "Available values: ",
>> - ".", ", ");
>> + _("Available values: "),
>> + _("."), _(", "));
>
> Hmm, it seems unclear (from the message catalog perspective) what the
> last two strings will be used for, so please add a /* translator */
> comment to each.
Actually, the ", " already exists in the message catalog, so adding a
comment here might confuse the other site.
Commits
-
Remove extraneous newlines from guc_parameters.dat
- a7f59b252a8e 19 (unreleased) landed
-
Fix NLS for incorrect GUC enum value hint message
- 0fc33b00536c 19 (unreleased) landed
-
Clean up qsort comparison function for GUC entries
- d2f24df19b7a 19 (unreleased) landed
-
Sort guc_parameters.dat alphabetically by name
- fce7c73fba4e 19 (unreleased) landed
-
Reorganize GUC structs
- a13833c35f9e 19 (unreleased) landed
-
Change config_generic.vartype to be initialized at compile time
- e1a912c86d52 19 (unreleased) landed
-
Use designated initializers for guc_tables
- 0a7bde461016 19 (unreleased) landed
-
Change reset_extra into a config_generic common field
- 5f4c3b33a976 19 (unreleased) landed
-
Add some const qualifiers
- 29dc7a668753 19 (unreleased) landed
-
Modernize some for loops
- 1a795188889c 19 (unreleased) landed