Horton

Re: analyze-in-stages post upgrade questions

Mircea Cadariu <cadariu.mircea@gmail.com>

View thread
From: Mircea Cadariu <cadariu.mircea@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>, "Zechman, Derek S" <Derek.S.Zechman@snapon.com>, Adrian Klaver <adrian.klaver@aklaver.com>, "pgsql-general@lists.postgresql.org" <pgsql-general@lists.postgresql.org>
Date: 2025-07-10T16:20:02Z
Lists: pgsql-hackers 
Hi Laurenz,


Got it. I have only one suggestion for the patch. Consider adding a 
corresponding test in src/bin/scripts/t/100_vacuumdb.pl.

Proposal (I used this to check the patch):

$node->safe_psql('postgres',
     "CREATE TABLE parent_table (a INT) PARTITION BY LIST (a);\n"
       . "CREATE TABLE child_table PARTITION OF parent_table FOR VALUES 
IN (1);\n"
       . "INSERT INTO parent_table VALUES (1);\n");
$node->issues_sql_like(
     [
         'vacuumdb', '--analyze-only', 'postgres'
     ],
     qr/statement:\s+ANALYZE\s+public\.parent_table/s,
     '--analyze_only updates statistics for partitioned tables');


Kind regards,

Mircea Cadariu