Horton
Menu

Re: patch: Use pg_assume in jsonb_util.c to fix GCC 15 warnings

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Peter Geoghegan <pg@bowt.ie>, Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Dmitry Mityugov <d.mityugov@postgrespro.ru>, pgsql-hackers@postgresql.org
Date: 2025-07-16T09:07:41Z
Lists: pgsql-hackers 
On 16.07.25 01:35, Peter Geoghegan wrote:
> On Sat, Jul 12, 2025 at 1:55 PM Andres Freund <andres@anarazel.de> wrote:
>> I had played with using pg_assume here too, but I couldn't really convince
>> myself that it's a good idea...
> 
> In the past, it was often necessary to work around MSVC's inability to
> see that a block containing elog(ERROR) doesn't actually need to
> initialize variables that'll never actually be used in code that comes
> after that block. We still have many "keep compiler quiet" variable
> initializations due to this.
> 
> Is that still something that we need to worry about? I don't recall
> running into it in quite a few years, though that might just be a
> coincidence.

Yes, this continues to be an unsolved problem.  See here for a recent 
discussion: 
https://www.postgresql.org/message-id/CAApHDvrFdXjbrV6KCx_GHKYSufUbNDYSsjppcJQiGOURfJE6qg@mail.gmail.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Clarify the ra != rb case in compareJsonbContainers().

  2. Silence uninitialized-value warnings in compareJsonbContainers().