Horton
Menu

Re: Add errdetail() with PID and UID about source of termination signal

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Andres Freund <andres@anarazel.de>
Cc: Jakub Wartak <jakub.wartak@enterprisedb.com>, Chao Li <li.evan.chao@gmail.com>, Jim Jones <jim.jones@uni-muenster.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-07T16:49:19Z
Lists: pgsql-hackers

Attachments

On 2026-04-07 Tu 10:55 AM, Andres Freund wrote:
>
> This seems completely wrong from a layering POV.  The wrapper has no business
> whatsoever to know that how SIGTERM is interpreted and thus no business
> setting variables like ProcDieSenderPid.
>
> Pretty sure have some sigterm handlers that shouldn't set ProcDieSenderPid.
>
>
> A more correct answer here would be to forward information about the sender of
> a signal to the signal handlers and let them interpret the information if
> available.
>

OK, fair points. Does the attached meet your concerns?


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Only show signal-sender PID/UID detail in server log

  2. Make psql DETAIL line test unconditionally optional.

  3. Rework signal handler infrastructure to pass sender info as argument.

  4. Add errdetail() with PID and UID about source of termination signal.