Re: HEAPDEBUGALL is broken

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alexander Lakhin <exclusion@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-04-21T18:01:53Z
Lists: pgsql-hackers
On 2020-04-19 22:00, Alexander Lakhin wrote:
> To the point, I've tried to use HAVE_ALLOCINFO on master today and it 
> failed too:
> $ CPPFLAGS="-DHAVE_ALLOCINFO" ./configure --enable-tap-tests 
> --enable-debug --enable-cassert  >/dev/null && make -j16 >/dev/null
> generation.c: In function ‘GenerationAlloc’:
> generation.c:191:11: error: ‘GenerationContext {aka struct 
> GenerationContext}’ has no member named ‘name’
>       (_cxt)->name, (_chunk), (_chunk)->size)
>             ^
> generation.c:386:3: note: in expansion of macro ‘GenerationAllocInfo’
>     GenerationAllocInfo(set, chunk);
>     ^~~~~~~~~~~~~~~~~~~
> generation.c:191:11: error: ‘GenerationContext {aka struct 
> GenerationContext}’ has no member named ‘name’
>       (_cxt)->name, (_chunk), (_chunk)->size)
>             ^
> generation.c:463:2: note: in expansion of macro ‘GenerationAllocInfo’
>    GenerationAllocInfo(set, chunk);
>    ^~~~~~~~~~~~~~~~~~~

Do you have a proposed patch?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Remove ACLDEBUG #define and associated code.

  2. Remove useless (and broken) logging logic in memory context functions.

  3. Remove HEAPDEBUGALL