Re: Virtual generated columns
Peter Eisentraut <peter@eisentraut.org>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
-
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
-
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
-
Virtual generated columns
- 83ea6c54025b 18.0 landed
-
Additional tests for stored generated columns
- 41084409f635 18.0 landed
-
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
-
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
-
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
-
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
-
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
-
Small code simplification
- 7ff9afbbd1df 18.0 landed
-
Remove useless code
- e26d313bad92 18.0 landed
-
Remove useless initializations
- da2aeba8f533 18.0 landed
-
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
-
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
-
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited
On 28.11.24 10:35, Peter Eisentraut wrote: > On 12.11.24 17:08, Peter Eisentraut wrote: >> On 11.11.24 12:37, jian he wrote: >>> On Wed, Nov 6, 2024 at 12:17 AM Peter Eisentraut >>> <peter@eisentraut.org> wrote: >>>> >>>> New patch version. I've gone through the whole thread again and looked >>>> at all the feedback and various bug reports and test cases and made >>>> sure >>>> they are all addressed in the latest patch version. (I'll send some >>>> separate messages to respond to some individual messages, but I'm >>>> keeping the latest patch here.) >>> >>> just quickly note the not good error message before you rebase. >>> >>> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS >>> (2) ; >>> ERROR: unrecognized constraint subtype: 4 >>> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS >>> (2) stored; >>> ERROR: unrecognized constraint subtype: 4 >>> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS >>> (2) virtual; >>> ERROR: unrecognized constraint subtype: 4 >>> >>> reading gram.y, typedef struct Constraint seems cannot distinguish, we >>> are creating a domain or create table. >>> I cannot found a way to error out in gram.y. >>> >>> so we have to error out at DefineDomain. >> >> This appears to be a very old problem independent of this patch. I'll >> take a look at fixing it. > > Here is a patch. > > I'm on the fence about taking out the default case. It does catch the > missing enum values, and I suppose if the struct arrives in > DefineDomain() with a corrupted contype value that is none of the enum > values, then we'd just do nothing with it. Maybe go ahead with this, > but for backpatching leave the default case in place? I have committed this, just to master for now.