Horton
Menu

Re: Amcheck verification of GiST and GIN

José Arthur Benetasso Villanova <jose.arthur@gmail.com>

View thread
From: Jose Arthur Benetasso Villanova <jose.arthur@gmail.com>
To: Andrey Borodin <amborodin86@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Andrey Borodin <x4mmm@yandex-team.ru>, Nikolay Samokhvalov <samokhvalov@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-12-14T12:18:44Z
Lists: pgsql-hackers 
On Sun, 27 Nov 2022, Andrey Borodin wrote:

> On Sun, Nov 27, 2022 at 1:29 PM Andrey Borodin <amborodin86@gmail.com> wrote:
>>
> I was wrong. GIN check does similar gin_refind_parent() to lock pages
> in bottom-up manner and truly verify downlink-child_page invariant.

Does this mean that we need the adjustment in docs?

> Here's v17. The only difference is that I added progress reporting to
> GiST verification.
> I still did not implement heapallindexed for GIN. Existence of pending
> lists makes this just too difficult for a weekend coding project :(
>
> Thank you!
>
> Best regards, Andrey Borodin.
>

I'm a bit lost here. I tried your patch again and indeed the 
heapallindexed inside gin_check_parent_keys_consistency has a TODO 
comment, but it's unclear to me if you are going to implement it or if the 
patch "needs review". Right now it's "Waiting on Author".

-- 
Jose Arthur Benetasso Villanova

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. amcheck: Fix posting tree checks in gin_index_check()

  2. amcheck: Fix parent key check in gin_index_check()

  3. amcheck: Fix checks of entry order for GIN indexes

  4. amcheck: Remove unused GinScanItem->parentlsn field

  5. amcheck: Test gin_index_check on a multicolumn index

  6. Remove incidental md5() function use from test

  7. amcheck: Add a GIN index to the CREATE INDEX CONCURRENTLY tests

  8. amcheck: Add a test with GIN index on JSONB data

  9. amcheck: Fix indentation in verify_gin.c

  10. amcheck: Add gin_index_check() to verify GIN index

  11. amcheck: Move common routines into a separate module

  12. Fix grammar in GIN README

  13. Avoid amcheck inline compression false positives.