Horton

Re: Frontend error logging style

Dmitry Koval <d.koval@postgrespro.ru>

View thread View on postgr.es
From: Dmitry Koval <d.koval@postgrespro.ru>
To: pgsql-hackers@lists.postgresql.org
Date: 2022-10-11T14:57:03Z
Lists: pgsql-hackers 
Hi!

Commit 9a374b77fb53 (Improve frontend error logging style.) replaced a 
line of file src/include/common/logging.h
```
extern PGDLLIMPORT enum pg_log_level __pg_log_level;
```
to
```
extern enum pg_log_level __pg_log_level;
```
i.e. it is rollback of commit 8ec569479fc28 (Apply PGDLLIMPORT markings 
broadly.)

Is it correct?

-- 
With best regards,
Dmitry Koval

Postgres Professional: http://postgrespro.com

Commits

  1. logging: Also add the command prefix to detail and hint messages

  2. Remove not-very-useful early checks of __pg_log_level in logging.h.

  3. Improve frontend error logging style.

  4. Apply PGDLLIMPORT markings broadly.