Horton

Re: SSL Tests for sslinfo extension

Andrew Dunstan <andrew@dunslane.net>

View thread View on postgr.es
From: Andrew Dunstan <andrew@dunslane.net>
To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>, Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-19T19:05:29Z
Lists: pgsql-hackers 
On 5/19/21 1:01 PM, Dagfinn Ilmari Mannsåker wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
>
>> In order to be able to test extensions with SSL connections, allow
>> configure_test_server_for_ssl to create any extensions passed as
>> comma separated list. Each extension is created in all the test
>> databases which may or may not be useful.
> Why the comma-separated string, rather than an array reference,
> i.e. `extensions => [qw(foo bar baz)]`?  Also, should it use `CREATE
> EXTENSION .. CASCADE`, in case the specified extensions depend on
> others?
>


Also, instead of one line per db there should be an inner loop over the
db  names.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Commits

  1. Use test-specific temp path for keys during SSL test

  2. Add TAP tests for contrib/sslinfo

  3. Extend configure_test_server_for_ssl to add extensions