Horton

Re: Performance regression with PostgreSQL 11 and partitioning

Thomas Reiss <thomas.reiss@dalibo.com>

View thread View on postgr.es
From: Thomas Reiss <thomas.reiss@dalibo.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <david.rowley@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, Amit Langote <amitlangote09@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-06-26T14:46:32Z
Lists: pgsql-hackers 

Le 26/06/2018 à 16:43, Alvaro Herrera a écrit :
> On 2018-Jun-25, Tom Lane wrote:
> 
>> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>>> On 2018-Jun-18, David Rowley wrote:
>>>> I've attached a patch which cleans up my earlier version and moves the
>>>> setup of the append_rel_array into its own function instead of
>>>> sneaking code into setup_simple_rel_arrays(). I've also now updated
>>>> the comment above find_childrel_appendrelinfo(), which is now an
>>>> unused function.
>>
>>> I checked that this patch fixes the originally reported performance
>>> regression.
>>> Unless there are objections, I intend to push this patch tomorrow.
>>
>> If find_childrel_appendrelinfo is now unused, we should remove it.
> 
> Agreed -- thanks for following up.  Pushed that way.

Thanks Alvaro, Ashutosh and David.

Commits

  1. Fix typo in comment

  2. Allow direct lookups of AppendRelInfo by child relid

  3. Teach adjust_appendrel_attrs(_multilevel) to do multiple translations.