Horton

Re: speeding up planning with partitions

Jesper Pedersen <jesper.pedersen@redhat.com>

View thread View on postgr.es
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: "Imai, Yoshikazu" <imai.yoshikazu@jp.fujitsu.com>, 'Amit Langote' <amitlangote09@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <david.rowley@2ndquadrant.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Justin Pryzby <pryzby@telsasoft.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2019-03-04T16:20:48Z
Lists: pgsql-hackers 
Hi Amit,

Passes check-world.

On 3/4/19 5:38 AM, Amit Langote wrote:
> See patch 0001.
> 

+* members of any appendrels we find here are added built later when

s/built//

> See patch 0002.
>

+		grouping_planner(root, false, 0.0 /* retrieve all tuples */);

Move comment out of function call.

+		if (root->simple_rte_array[childRTindex])
+			elog(ERROR, "rel %d already exists", childRTindex);
+		root->simple_rte_array[childRTindex] = childrte;
+		if (root->append_rel_array[childRTindex])
+			elog(ERROR, "child relation %d already exists", childRTindex);
+		root->append_rel_array[childRTindex] = appinfo;


Could the "if"s be made into Assert's instead ?

+ *		the	newly added bytes with zero

Extra spaces

+	if (rte->rtekind == RTE_RELATION &&	!root->contains_inherit_children)

s/TAB/space

> See patch 0003.
> 

+	 * because they correspond to flattneed UNION ALL subqueries.  Especially,

s/flattneed/flatten

> See patch 0004.
> 

+	 * no need to make any new entries, because anything that'd need those

Use "would" explicit

+ * this case, since it needn't be scanned.

, since it doesn't need to be scanned

> See patch 0005.
>
> See patch 0006.
>

I'll run some tests using a hash partitioned setup.

Best regards,
  Jesper

Commits

  1. Clean up handling of constraint_exclusion and enable_partition_pruning.

  2. Add test case exercising formerly-unreached code in inheritance_planner.

  3. Speed up planning when partitions can be pruned at plan time.

  4. Avoid crash in partitionwise join planning under GEQO.

  5. Avoid passing query tlist around separately from root->processed_tlist.

  6. Build "other rels" of appendrel baserels in a separate step.

  7. Get rid of duplicate child RTE for a partitioned table.

  8. Rearrange make_partitionedrel_pruneinfo to avoid work when we can't prune.

  9. Don't copy PartitionBoundInfo in set_relation_partition_info.

  10. Move building of child base quals out into a new function

  11. Reorganize planner code moved in b60c39759908

  12. Move inheritance expansion code into its own file

  13. Fix inherited UPDATE/DELETE with UNION ALL subqueries.

  14. Rearrange planner to save the whole PlannerInfo (subroot) for a subquery.