Re: postgres_fdw batching vs. (re)creating the tuple slots

On 6/9/21 1:08 PM, Tomas Vondra wrote:
> 
> 
> On 6/9/21 12:50 PM, Bharath Rupireddy wrote:
>> On Wed, Jun 9, 2021 at 4:00 PM Tomas Vondra
>> <tomas.vondra@enterprisedb.com> wrote:
>>>
>>> Hi,
>>>
>>> Here's a v2 fixing a silly bug with reusing the same variable in two
>>> nested loops (worked for simple postgres_fdw cases, but "make check"
>>> failed).
>>
>> I applied these patches and ran make check in postgres_fdw contrib
>> module, I saw a server crash. Is it the same failure you were saying
>> above?
>>
> 
> Nope, that was causing infinite loop. This is jut a silly mistake on my
> side - I forgot to replace the i/j variable inside the loop. Here's v3.
> 
> regards
> 

FWIW I've pushed this, after improving the comments a little bit.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company