Horton
Menu

Re: Do we still need gen_node_support.pl's nodetag ABI stability check?

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Date: 2026-04-15T19:30:17Z
Lists: pgsql-hackers 
On 14.04.26 07:04, Tom Lane wrote:
> On the one hand, there's much to be said for belt-and-suspenders-too
> safety checks.  On the other hand, updating gen_node_support.pl is
> an extra manual step while creating a branch, so it's easy to forget
> or get wrong.  It's also not very clear why this particular sort
> of ABI break in a stable branch is any worse than other hazards.

This might still be helpful because it checks during local builds and 
doesn't rely on the buildfarm.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Remove gen_node_support.pl's ad-hoc ABI stability check.

  2. Add defenses against unexpected changes in the NodeTag enum list.