Un peu décu : Re: Performance regression with PostgreSQL 11 and partitioning
Christophe Courtois <christophe.courtois@dalibo.com>
From: Christophe Courtois <christophe.courtois@dalibo.com>
To: Thomas Reiss <thomas.reiss@dalibo.com>
Cc: David Rowley <david.rowley@2ndquadrant.com>,
Robert Haas <robertmhaas@gmail.com>,
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>,
Amit Langote <amitlangote09@gmail.com>,
"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2018-07-09T12:47:51Z
Lists: pgsql-hackers
Hello, J'ai eu peur, 7d872c91a3f9d49b56117557cdbb0c3d4c620687 n'est pas en bêta 2 mais bien dans REL_11_STABLE. J'ai relancé mes scripts avec 10000 partitions vides, un peu à l'arrache et sans rigueur : la dernière version incluant ce patch est effectivement souvent moitié plus rapide qu'en 10, mais si je joins deux tables à 10000 partitions entre elles, ça devient 2 fois plus catastrophique. Bref, un sacré progrès quand même. Merci d'avoir porté ça sur hackers. Le 26/06/2018 à 16:46, Thomas Reiss a écrit : > > > Le 26/06/2018 à 16:43, Alvaro Herrera a écrit : >> On 2018-Jun-25, Tom Lane wrote: >> >>> Alvaro Herrera <alvherre@2ndquadrant.com> writes: >>>> On 2018-Jun-18, David Rowley wrote: >>>>> I've attached a patch which cleans up my earlier version and moves the >>>>> setup of the append_rel_array into its own function instead of >>>>> sneaking code into setup_simple_rel_arrays(). I've also now updated >>>>> the comment above find_childrel_appendrelinfo(), which is now an >>>>> unused function. >>> >>>> I checked that this patch fixes the originally reported performance >>>> regression. >>>> Unless there are objections, I intend to push this patch tomorrow. >>> >>> If find_childrel_appendrelinfo is now unused, we should remove it. >> >> Agreed -- thanks for following up. Pushed that way. > > Thanks Alvaro, Ashutosh and David. > > > -- Christophe Courtois Consultant Dalibo http://dalibo.com/ - http://dalibo.org/
Commits
-
Fix typo in comment
- f5545287dc5f 11.0 landed
-
Allow direct lookups of AppendRelInfo by child relid
- 7d872c91a3f9 11.0 landed
-
Teach adjust_appendrel_attrs(_multilevel) to do multiple translations.
- 480f1f4329f1 11.0 cited