Horton

Thread

Commits

  1. doc: Correct the description about the length of pg_stat_activity.query.

  1. [doc] modifying unit from characters to bytes

    torikoshia <torikoshia@oss.nttdata.com> — 2020-07-08T01:54:42Z

    Hi,

The manual describes the size of pg_stat_activity.query
as below:

  | By default the query text is truncated at 1024 characters;

When considering multibyte characters, it seems more
accurate to change the unit from "characters" to "bytes".

I also searched other "[0-9] characters" in the manual.
I may overlook something, but apparently it seems ok
because of their contexts which are limited to ASCII
character or other reasons.


Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

  2. Re: [doc] modifying unit from characters to bytes

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-07-08T02:25:26Z

    
On 2020/07/08 10:54, torikoshia wrote:
> Hi,
> 
> The manual describes the size of pg_stat_activity.query
> as below:
> 
>   | By default the query text is truncated at 1024 characters;
> 
> When considering multibyte characters, it seems more
> accurate to change the unit from "characters" to "bytes".

Agreed. Barring any objection, I will commit this patch.

For record, this change derived from the discussion about other patch [1].

Regards,

[1]
https://postgr.es/m/cd0e961fd42e5708fdea70f7420bf214@oss.nttdata.com


-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  3. Re: [doc] modifying unit from characters to bytes

    Daniel Gustafsson <daniel@yesql.se> — 2020-07-08T07:17:45Z

    > On 8 Jul 2020, at 04:25, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> 
> On 2020/07/08 10:54, torikoshia wrote:
>> Hi,
>> The manual describes the size of pg_stat_activity.query
>> as below:
>>  | By default the query text is truncated at 1024 characters;
>> When considering multibyte characters, it seems more
>> accurate to change the unit from "characters" to "bytes".
> 
> Agreed. Barring any objection, I will commit this patch.

+1 to commit this patch, following the link to track_activity_query_size it's
even specified to be bytes there.  IIRC the NULL terminator is also included in
the 1024 bytes which prevents it from being 1024 characters even for
non-multibyte.

cheers ./daniel

  4. Re: [doc] modifying unit from characters to bytes

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-07-08T08:05:47Z

    
On 2020/07/08 16:17, Daniel Gustafsson wrote:
>> On 8 Jul 2020, at 04:25, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> On 2020/07/08 10:54, torikoshia wrote:
>>> Hi,
>>> The manual describes the size of pg_stat_activity.query
>>> as below:
>>>   | By default the query text is truncated at 1024 characters;
>>> When considering multibyte characters, it seems more
>>> accurate to change the unit from "characters" to "bytes".
>>
>> Agreed. Barring any objection, I will commit this patch.
> 
> +1 to commit this patch, following the link to track_activity_query_size it's
> even specified to be bytes there.  IIRC the NULL terminator is also included in
> the 1024 bytes which prevents it from being 1024 characters even for
> non-multibyte.

Yes, so we should document "truncated at 1023 bytes" for accuracy, instead?
This might be more confusing for users, though....

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  5. Re: [doc] modifying unit from characters to bytes

    Daniel Gustafsson <daniel@yesql.se> — 2020-07-08T08:12:18Z

    > On 8 Jul 2020, at 10:05, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
> 
> On 2020/07/08 16:17, Daniel Gustafsson wrote:
>>> On 8 Jul 2020, at 04:25, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>> 
>>> On 2020/07/08 10:54, torikoshia wrote:
>>>> Hi,
>>>> The manual describes the size of pg_stat_activity.query
>>>> as below:
>>>>  | By default the query text is truncated at 1024 characters;
>>>> When considering multibyte characters, it seems more
>>>> accurate to change the unit from "characters" to "bytes".
>>> 
>>> Agreed. Barring any objection, I will commit this patch.
>> +1 to commit this patch, following the link to track_activity_query_size it's
>> even specified to be bytes there.  IIRC the NULL terminator is also included in
>> the 1024 bytes which prevents it from being 1024 characters even for
>> non-multibyte.
> 
> Yes, so we should document "truncated at 1023 bytes" for accuracy, instead?
> This might be more confusing for users, though....

I think that's overcomplicating things, since we do (will) specify bytes and
not characters.

cheers ./daniel

  6. Re: [doc] modifying unit from characters to bytes

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-07-09T04:47:27Z

    
On 2020/07/08 17:12, Daniel Gustafsson wrote:
>> On 8 Jul 2020, at 10:05, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> On 2020/07/08 16:17, Daniel Gustafsson wrote:
>>>> On 8 Jul 2020, at 04:25, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>>>
>>>> On 2020/07/08 10:54, torikoshia wrote:
>>>>> Hi,
>>>>> The manual describes the size of pg_stat_activity.query
>>>>> as below:
>>>>>   | By default the query text is truncated at 1024 characters;
>>>>> When considering multibyte characters, it seems more
>>>>> accurate to change the unit from "characters" to "bytes".
>>>>
>>>> Agreed. Barring any objection, I will commit this patch.
>>> +1 to commit this patch, following the link to track_activity_query_size it's
>>> even specified to be bytes there.  IIRC the NULL terminator is also included in
>>> the 1024 bytes which prevents it from being 1024 characters even for
>>> non-multibyte.
>>
>> Yes, so we should document "truncated at 1023 bytes" for accuracy, instead?
>> This might be more confusing for users, though....
> 
> I think that's overcomplicating things, since we do (will) specify bytes and
> not characters.

Agreed. So I pushed the proposed patch. Thanks!

Regards,


-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  7. Re: [doc] modifying unit from characters to bytes

    torikoshia <torikoshia@oss.nttdata.com> — 2020-07-09T12:59:32Z

    On 2020-07-09 13:47, Fujii Masao wrote:
> On 2020/07/08 17:12, Daniel Gustafsson wrote:
>>> On 8 Jul 2020, at 10:05, Fujii Masao <masao.fujii@oss.nttdata.com> 
>>> wrote:
>>> 
>>> On 2020/07/08 16:17, Daniel Gustafsson wrote:
>>>>> On 8 Jul 2020, at 04:25, Fujii Masao <masao.fujii@oss.nttdata.com> 
>>>>> wrote:
>>>>> 
>>>>> On 2020/07/08 10:54, torikoshia wrote:
>>>>>> Hi,
>>>>>> The manual describes the size of pg_stat_activity.query
>>>>>> as below:
>>>>>>   | By default the query text is truncated at 1024 characters;
>>>>>> When considering multibyte characters, it seems more
>>>>>> accurate to change the unit from "characters" to "bytes".
>>>>> 
>>>>> Agreed. Barring any objection, I will commit this patch.
>>>> +1 to commit this patch, following the link to 
>>>> track_activity_query_size it's
>>>> even specified to be bytes there.  IIRC the NULL terminator is also 
>>>> included in
>>>> the 1024 bytes which prevents it from being 1024 characters even for
>>>> non-multibyte.
>>> 
>>> Yes, so we should document "truncated at 1023 bytes" for accuracy, 
>>> instead?
>>> This might be more confusing for users, though....
>> 
>> I think that's overcomplicating things, since we do (will) specify 
>> bytes and
>> not characters.
> 
> Agreed. So I pushed the proposed patch. Thanks!

Thanks for applying!

Regards,


--
Atsushi Torikoshi
NTT DATA CORPORATION