Horton
Menu

Re: small cleanup patches for collation code

Peter Eisentraut <peter@eisentraut.org>

View thread
From: Peter Eisentraut <peter@eisentraut.org>
To: Jeff Davis <pgsql@j-davis.com>, pgsql-hackers@postgresql.org
Date: 2026-04-25T06:12:07Z
Lists: pgsql-hackers 
On 17.04.26 21:30, Jeff Davis wrote:
> Two patches attached.
> 
> 0001 fixes a style issue. Backport because it eliminates a warning in
> the 'update-unicode' target.

These warning options were only added in PG19, so backpatching is not 
necessary.

> 0002 looks like a bug, but is not a real issue because there are no
> callers that pass srclen==-1, aside from a test (which fails to fail).
> So it's just cleanup, but it seems worth backporting.

That looks right.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix callers of unicode_strtitle() using srclen == -1.

  2. style: define parameterless functions as foo(void).