Horton
Menu

Re: run pgindent on a regular basis / scripted manner

Andrew Dunstan <andrew@dunslane.net>

View thread
From: Andrew Dunstan <andrew@dunslane.net>
To: Jelte Fennema <postgres@jeltef.nl>
Cc: "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>, Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>, Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>, Magnus Hagander <magnus@hagander.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2023-02-14T16:46:24Z
Lists: pgsql-hackers 
On 2023-02-13 Mo 13:29, Jelte Fennema wrote:
> On Mon, 13 Feb 2023 at 17:47, Andrew Dunstan<andrew@dunslane.net>  wrote:
>> OK, but I'd like to hear from more people about what they want. Experience tells me that making assumptions about how people work is not a good idea. I doubt anyone's work pattern is like mine. I don't want to implement an option that three people are going to use.
>
> In the general case I agree with you. But in this specific case I
> don't. To me the whole point of this email thread is to nudge people
> towards indenting the changes that they are committing. Thus indenting
> those changes (either before or after adding) is the workflow that we
> want to make as easy as possible. Because even if it's not people
> their current workflow, by adding the flag it hopefully becomes their
> workflow, because it's so easy to use. So my point is we want to
> remove as few hurdles as possible for people to indent their changes
> (and setting up git aliases or pre-commit hooks are all hurdles).


(ITYM "remove as many hurdles as possible"). It remains to be seen how 
much easier any of this will make life for committers, at least. But I 
concede this might make life a bit simpler for developers generally.

Anyway, let's talk about the details of what is proposed.

So far, we have had the following categories suggested: dirty, staged, 
dirty+staged, untracked. Are there any others?

Another issue is whether or not to restrict these to files under the 
current directory. I think we probably should, or at least provide a 
--relative option.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix comment from commit 22655aa231.

  2. Add a few recent commits to .git-blame-ignore-revs.

  3. Pre-beta2 mechanical code beautification.

  4. Pre-beta mechanical code beautification.

  5. Make agreed-on updates in perltidy options.

  6. Remove obsolete pgindent options --code-base and --build

  7. Integrate pg_bsd_indent into our build/test infrastructure.

  8. Sync pg_bsd_indent's copyright notices with Postgres practice.

  9. Import pg_bsd_indent sources.

  10. pgindent: filter files for the --commit option

  11. pgindent: more ways to find files to indent

  12. Fix pgindent --show-diff option.

  13. Add non-destructive modes to pgindent

  14. Initial pgindent run with pg_bsd_indent version 2.0.