Re: BUG #18943: Return value of a function 'xmlBufferCreate' is dereferenced at xpath.c:177 without checking for NUL

Jim Jones <jim.jones@uni-muenster.de>

From: Jim Jones <jim.jones@uni-muenster.de>

To: Michael Paquier <michael@paquier.xyz>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-bugs@lists.postgresql.org, maralist86@mail.ru

Date: 2025-06-08T08:33:17Z

Lists: pgsql-bugs

On 08.06.25 04:19, Michael Paquier wrote:
> ERRCODE_INTERNAL_ERROR would be more adapted, I'm only seeing error
> code paths caused by inconsistencies in the nodes.

+1

> I have updated the patches with the attached, splitting the parts for
> contrib/xml2/ and the backend into two parts.  These touch error paths
> that are very unlikely going to be hit in practice, so let's do all
> that once v19 opens for business only on HEAD.

Out of curiosity, why aren't we applying this to v18?

Overall, LGTM.

Thanks!

-- 
Jim

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

xml2: Fix failure with xslt_process() under -fsanitize=undefined
- 70f7c5badcc0 14.23 landed
- 0b0041b942f7 15.18 landed
- 5f46c617e95f 16.14 landed
- 63aa4342da23 17.10 landed
- e33a4fda0027 18.4 landed
- 7d64419f8073 19 (unreleased) landed
Fix misuse of "volatile" in xml.c
- 6307b096e259 19 (unreleased) landed
xml2: Improve error handling of libxml2 calls
- 732061150b00 19 (unreleased) landed
Improve error handling of libxml2 calls in xml.c
- 2e947217474c 19 (unreleased) landed