Horton

Re: [PATCH] Const'ify the arguments of ilist.c/ilist.h functions

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Aleksander Alekseev <aleksander@timescale.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, David Rowley <dgrowleyml@gmail.com>
Date: 2023-01-12T07:34:25Z
Lists: pgsql-hackers 
On 07.01.23 08:21, Peter Eisentraut wrote:
> On 23.11.22 14:57, Aleksander Alekseev wrote:
>> Hi Andres,
>>
>> Thanks for the review!
>>
>>> I don't think it is correct for any of these to add const. The only 
>>> reason it
>>> works is because of casting etc.
>>
>> Fair enough. PFA the corrected patch v2.
> 
> This patch version looks correct to me.  It is almost the same as the 
> one that Andres had posted in his thread, except that yours also 
> modifies slist_delete() and dlist_member_check().  Both of these changes 
> also look correct to me.

committed

Commits

  1. Fix ILIST_DEBUG build

  2. Constify the arguments of ilist.c/h functions