Re: Allow CURRENT_ROLE in GRANTED BY
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Date: 2020-08-26T11:00:57Z
Lists: pgsql-hackers
Attachments
- v3-0001-Allow-CURRENT_ROLE-where-CURRENT_USER-is-accepted.patch (text/plain) patch v3-0001
On 2020-06-29 14:47, Peter Eisentraut wrote: > On 2020-06-24 23:08, Alvaro Herrera wrote: >> On 2020-Jun-24, Peter Eisentraut wrote: >> >>> I was checking some loose ends in SQL conformance, when I noticed: We >>> support GRANT role ... GRANTED BY CURRENT_USER, but we don't support >>> CURRENT_ROLE in that place, even though in PostgreSQL they are equivalent. >>> Here is a trivial patch to add that. >> >> Hmm, since this adds to RoleSpec, this change makes every place that >> uses that production also take CURRENT_ROLE, so we'd need to document in >> all those places. For example, alter_role.sgml, create_schema.sgml, >> etc. > > Good point. Here is an updated patch that updates all the documentation > places where CURRENT_USER is mentioned. Here is another patch that also makes comprehensive updates to the rolenames tests under src/test/modules/unsafe_tests/. I think this should now cover all the required ancillary changes. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Fix GRANTED BY support in REVOKE ROLE statements
- b2a459edfe64 15.0 landed
- 371087d006e0 14.2 landed
-
Allow GRANTED BY clause in normal GRANT and REVOKE statements
- 6aaaa76bb47d 14.0 landed
-
Try to stabilize output from rolenames regression test.
- e5209bf37a27 14.0 landed
-
Allow CURRENT_ROLE where CURRENT_USER is accepted
- 45b9805706fd 14.0 landed