Re: fairywren hung in pg_basebackup tests
Andrew Dunstan <andrew@dunslane.net>
From: Andrew Dunstan <andrew@dunslane.net>
To: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-07-25T16:02:57Z
Lists: pgsql-hackers
On 2022-07-25 Mo 11:24, Thomas Munro wrote: > On Tue, Jul 26, 2022 at 3:08 AM Tom Lane <tgl@sss.pgh.pa.us> wrote: >> I wrote: >>> Right, so the "glob" failed to find anything. Seeing that this test >>> is new as of 534472375, which postdates fairywren's last successful >>> run, I'd guess that the "glob" needs adjustment for msys path names. > The test added by 534472375 is at the end, hundreds of lines later > than the one that appears to be failing. Right. > >> Hmm ... an alternative theory is that the test is fine, and what >> it's telling us is that get_dirent_type() is still wrong on msys. >> Would that end in this symptom? > Hmm, possibly yes (if it sees a non-symlink, it'll skip it). If > someone can run the test on an msys system, perhaps they could put a > debugging elog() into the code modified by 9d3444dc to log d_name and > the d_type that is returned? I'm struggling to understand why msys > would change the answer though. I have no idea either. The link exists and it is a junction. I'll see about logging details. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com
Commits
-
Fix get_dirent_type() for symlinks on MinGW/MSYS.
- fc4e5af30749 15.0 landed
- 5ad478c9d956 14.5 landed
- 4fc6b6eefcf9 16.0 landed