Re: SQL/JSON path issues/questions
Liudmila Mantrova <l.mantrova@postgrespro.ru>
From: Liudmila Mantrova <l.mantrova@postgrespro.ru>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Thom Brown <thom@linux.com>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-07-04T13:38:14Z
Lists: pgsql-hackers
Attachments
- 0004-clarify-jsonpath-docs-4.patch (text/x-patch) patch 0004
On 7/3/19 11:59 PM, Alexander Korotkov wrote: > Hi! > > On Wed, Jul 3, 2019 at 5:27 PM Liudmila Mantrova > <l.mantrova@postgrespro.ru> wrote: >> I have rechecked the standard and I agree that we should use "filter >> expression" whenever possible. >> "A filter expression must be enclosed in parentheses..." looks like an >> oversight, so I fixed it. As for what's actually enclosed, I believe we >> can still use the word "condition" here as it's easy to understand and >> is already used in our docs, e.g. in description of the WHERE clause >> that serves a similar purpose. >> The new version of the patch fixes the terminology, tweaks the examples, >> and provides some grammar and style fixes in the jsonpath-related chapters. > > It looks good to me. But this sentence looks a bit too complicated. > > "It can be followed by one or more accessor operators to define the > JSON element on a lower nesting level by which to filter the result." > > Could we phrase this as following? > > "In order to filter the result by values lying on lower nesting level, > @ operator can be followed by one or more accessor operators." > > ------ > Alexander Korotkov > Postgres Professional: http://www.postgrespro.com > The Russian Postgres Company Thank you! I think we can make this sentence even shorter, the fix is attached: "To refer to a JSON element stored at a lower nesting level, add one or more accessor operators after <literal>@</literal>." -- Liudmila Mantrova Technical writer at Postgres Professional: http://www.postgrespro.com The Russian Postgres Company
Commits
-
Fixes for jsonpath filter expression elements table in docs
- 1ed89826b82c 12.0 landed
- 0cea6eb5a5f2 13.0 landed
-
Assorted fixes for jsonpath documentation
- a5c2f3a346fc 12.0 landed
- 5a7d697a3936 13.0 landed
-
Fix description for $varname jsonpath variable
- dfd79e2d0e8f 12.0 landed
-
Improve documentation for jsonpath like_regex predicate
- 1ff8dc9f19dd 12.0 landed
-
Support 'q' flag in jsonpath 'like_regex' predicate
- 261a5c192856 12.0 landed