Re: Bogus HAVE_DECL_FOO entries in msvc/Solution.pm

Peter Eisentraut <peter.eisentraut@enterprisedb.com>

From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2021-07-13T15:01:53Z
Lists: pgsql-hackers
On 13.07.21 09:53, Michael Paquier wrote:
> I was thinking to just do the easiest move and fix this issue down to
> 13, not bothering about older branches :p
> 
> Looking at the commit, a backpatch is not that complicated and it is
> possible to check the generation of pg_config.h on non-MSVC
> environments if some objects are missing.  Still, I think that it
> would be better to be careful and test this code properly on Windows
> with a real build.  It means that..  Err...  Andrew or I should look
> at that.  I am not sure that the potential maintenance gain is worth
> poking at the stable branches, to be honest.

We have lived with the previous system for a decade, so I think 
backpatching this would be a bit excessive.



Commits

  1. Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.