Re: Design of pg_stat_subscription_workers vs pgstats
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Amit Kapila
<amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>,
"David G. Johnston" <david.g.johnston@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-02-24T12:23:55Z
Lists: pgsql-hackers
On 24.02.22 12:46, Masahiko Sawada wrote: >> We have a view called pg_stat_activity, which is very well known. From >> that perspective, "activity" means what is happening right now or what >> has happened most recently. The reworked view in this patch does not >> contain that (we already have pg_stat_subscription for that), but it >> contains accumulated counters. > Right. > > What pg_stat_subscription shows is rather suitable for the name > pg_stat_subscription_activity than the reworked view. But switching > these names would also not be a good idea. I think it's better to use > "subscription" in the view name since it shows actually statistics for > subscriptions and subscription OID is the key. I personally prefer > pg_stat_subscription_counters among the ideas that have been proposed > so far, but I'd like to hear opinions and votes. _counters will fail if there is something not a counter (such as last-timestamp-of-something). Earlier, pg_stat_subscription_stats was mentioned, which doesn't have that problem.
Commits
-
Reconsider pg_stat_subscription_workers view.
- 7a8507329085 15.0 landed
-
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 cited