Re: BackgroundPsql swallowing errors on windows

Andres Freund <andres@anarazel.de>

From: Andres Freund <andres@anarazel.de>

To: Michael Paquier <michael@paquier.xyz>

Cc: Jacob Champion <jacob.champion@enterprisedb.com>, Daniel Gustafsson <daniel@yesql.se>, Michael Paquier <michael.paquier@gmail.com>, Heikki Linnakangas <heikki.linnakangas@iki.fi>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Noah Misch <noah@leadboat.com>

Date: 2025-02-19T15:41:53Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

tests: BackgroundPsql: Fix potential for lost errors on windows
- bb2bf22761e1 13.21 landed
- c21ebcca7965 14.18 landed
- 70b650d18553 15.13 landed
- 4c9397c374d9 16.9 landed
- f61769adaa62 17.5 landed
- 8b886a4e3488 18.0 landed
Improve handling of empty query results in BackgroundPsql::query()
- 70291a3c66ec 18.0 cited
Extend Cluster.pm's background_psql() to be able to start asynchronously
- ba08edb06545 18.0 cited

Hi,

On 2025-02-17 09:24:24 +0900, Michael Paquier wrote:
> On Sun, Feb 16, 2025 at 07:03:39PM -0500, Andres Freund wrote:
> > Cool, will after the minor release freeze.
>
> Thanks, Andres.  If you'd prefer that I double-check the code and do
> it as the former committer of these two ones, please let me know.

Thanks, but I think it's ok, it looks unproblematic enough. I've pushed the
backports (but not yet the new fix), after running them through CI [1].  Let's
hope the buildfarm thinks similarly.

I'm planning to wait for a few hours and see what the BF says and then push
the fix this thread is about to all supported branches.

Greetings,

Andres Freund

[1] I have WIP patches for CI support for 13, 14, with some work for windows
    left to do. I plan to write an email about that at some point.