Horton

Re: define pg_structiszero(addr, s, r)

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Ranier Vilela <ranier.vf@gmail.com>, David Rowley <dgrowleyml@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@lists.postgresql.org
Date: 2024-11-15T07:49:26Z
Lists: pgsql-hackers 
On Fri, Nov 15, 2024 at 06:46:52AM +0000, Bertrand Drouvot wrote:
> Makes sense even if that looks "more difficult" to read.

I don't think it's that "bad".

> which is adding a "." at the end of single line comments (as the few already
> part of this file don't do so).

I did so after looking at the surroundings.  One way or the other is
fine by me as long as we're consistent.

I still need to have a second look.  For now, let's wait a bit, in
case there are any comments.
--
Michael

Commits

  1. Use pg_memory_is_all_zeros() in PageIsVerifiedExtended()

  2. Optimize pg_memory_is_all_zeros() in memutils.h

  3. Remove use of pg_memory_is_all_zeros() in bufpage.c

  4. Add pg_memory_is_all_zeros() in memutils.h