Horton

Re: nbtree VACUUM's REDO routine doesn't clear page's VACUUM cycle ID

Michael Paquier <michael@paquier.xyz>

View thread
From: Michael Paquier <michael@paquier.xyz>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-20T06:32:11Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reset btpo_cycleid in nbtree VACUUM's REDO routine.

On Fri, Nov 15, 2024 at 11:33:37AM -0500, Peter Geoghegan wrote:
> Attached patch teaches btree_xlog_vacuum, nbtree VACUUM's REDO
> routine, to reset the target page's opaque->btpo_cycleid to 0. This
> makes the REDO routine match original execution, which seems like a
> good idea on consistency grounds.
> 
> I propose this for the master branch only.

Perhaps this patch should also explain why this is better this way?
This path does not manipulate btpo_level, for one.
--
Michael