Re: Clear padding in PgStat_HashKey keys
Michael Paquier <michael@paquier.xyz>
From: Michael Paquier <michael@paquier.xyz>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-11-04T09:49:04Z
Lists: pgsql-hackers
On Mon, Nov 04, 2024 at 08:52:04AM +0000, Bertrand Drouvot wrote: > Yeah, but not only the relfilenode ones. All kinds were affected as random data > was in the padding bytes for all of them. A quick test where I add some padding junk in PgStat_HashKey proves that you are right. I'm wondering if we should backpatch that, actually, down to where it has been introduced. We are unlikely going to change this structure, but if we do for the sake of a bug fix, which is always a possibility as ABI does not matter much for this internal structure, that's potentially trouble waiting ahead. Thoughts? -- Michael
Commits
-
Clear padding of PgStat_HashKey when handling pgstats entries
- 6d5e6693ee6b 15.9 landed
- 925b3aa85700 16.5 landed
- 7f3b41ce48a5 17.1 landed
- 7d85d87f4d5c 18.0 landed