Horton

Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description

Bruce Momjian <bruce@momjian.us>

View thread View on postgr.es
From: Bruce Momjian <bruce@momjian.us>
To: Peter Smith <smithpb2250@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, shveta.malik@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2024-10-31T17:35:20Z
Lists: pgsql-hackers

Attachments

On Thu, Oct 24, 2024 at 08:32:54AM +1100, Peter Smith wrote:
> Hi. Here are a couple of minor comments.
> 
> 1.
> +        The time slot synchronization (see <xref
> +        linkend="logicaldecoding-replication-slots-synchronization"/>)
> +        was most recently stopped.
> 
> /The time slot/The time when slot/
> 
> ~~~
> 
> 2.
> - /* The time since the slot has become inactive */
> + /* The time slot sychronized was stopped. */
> 
> 
> Maybe just make this comment the same as the sentence used in the docs:
> - e.g. add "when"; fix, typo "sychronized", etc.
> 
> 
> /The time slot sychronized was stopped./The time when slot
> synchronization was most recently stopped./

Yes, all good suggestions, updated patch attached.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"

Commits

  1. Doc: Clarify the `inactive_since` field description.

  2. Change last_inactive_time to inactive_since in pg_replication_slots.