Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Bruce Momjian <bruce@momjian.us>
From: Bruce Momjian <bruce@momjian.us>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, "David G. Johnston" <david.g.johnston@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, shveta.malik@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2024-10-31T17:22:51Z
Lists: pgsql-hackers
Attachments
- inactive.diff (text/x-diff) patch
On Fri, Oct 18, 2024 at 04:25:33PM +0530, Amit Kapila wrote: > Few comments: > ============= > 1. > <para> > - True if this slot is currently actively being used > + True if this slot is currently currently being streamed > </para></entry> > > currently shouldn't be used twice. > > 2. > - /* The time since the slot has become inactive */ > + /* The time slot sychronized was stopped. */ > TimestampTz inactive_since; > > Would it be better to say: "The time slot synchronization was stopped."? > > 3. > This is useful for slots on the > + standby that are intended to be synced from a primary server > > I think it is better to be explicit here and probably say: "This is > useful for slots on the standby that are being synced from a primary > server .." Agreed, fixed in the attached patch. -- Bruce Momjian <bruce@momjian.us> https://momjian.us EDB https://enterprisedb.com When a patient asks the doctor, "Am I going to die?", he means "Am I going to die soon?"
Commits
-
Doc: Clarify the `inactive_since` field description.
- d05a387d9d78 18.0 landed
- 5f46439d5931 17.3 landed
-
Change last_inactive_time to inactive_since in pg_replication_slots.
- 6d49c8d4b4f4 17.0 cited