Horton

Re: Add isolation test template in injection_points for wait/wakeup/detach

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-10-30T09:27:13Z
Lists: pgsql-hackers 
Hi,

On Wed, Oct 30, 2024 at 06:21:04PM +0900, Michael Paquier wrote:
> On Wed, Oct 30, 2024 at 07:26:07AM +0000, Bertrand Drouvot wrote:
> > 1 === Nit
> > 
> > s/Permutations like this one/Permutations like the following commented out one/ ?
> > 
> > 2 ===
> > 
> > s/back its result/back its result once woken up/ ?
> > 
> > 3 ===
> > 
> > s/faster than the wait/before the SQL function doing the wait returns its result/ ?
> > 
> > With 2 === and 3 === I think it's easier to "link" both sentences that way.
> 
> What do you think about the updated version attached?

Thanks! LGTM.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. injection_points: Tweak more permutation in isolation test "basic"

  2. injection_points: Re-enable permutation in isolation test "basic"

  3. injection_points: Improve comment about disabled isolation permutation

  4. injection_points: Disable one permutation in isolation test "basic"

  5. injection_points: Add basic isolation test