Re: define pg_structiszero(addr, s, r)
Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers@lists.postgresql.org
Date: 2024-10-29T14:03:02Z
Lists: pgsql-hackers
Hi, On Tue, Oct 29, 2024 at 11:39:03AM +0200, Heikki Linnakangas wrote: > On 29/10/2024 09:54, Bertrand Drouvot wrote: > > > https://godbolt.org/z/x9hPWjheq. > > > > Yeah, I also think that's fine. Peter Smith did some testing in [1] comparing > > memcmp and simple loop checking (thanks Peter for the testing!): > > > > " > > Iterate 1000000 times... > > check zeros using loop -- elapsed=0.041196s > > check zeros using memcmp -- elapsed=0.016407s > > " > > > > So, in this test, the loop is 0.024789s longer means 0.024789s/1000000=24 Nanosecond > > slower per comparison (If my math is correct). > > I believe that test program is bogus. Look at the assembly code; the > compiler optimized away the loops. Oh right. It looks like that moving the "scanf" within each loop "helps" and that both give pretty comparable results. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Commits
-
Use pg_memory_is_all_zeros() in PageIsVerifiedExtended()
- 03a42c9652f8 18.0 landed
-
Optimize pg_memory_is_all_zeros() in memutils.h
- 5be1dabd2ae0 18.0 landed
-
Remove use of pg_memory_is_all_zeros() in bufpage.c
- e819bbb7c82a 18.0 landed
-
Add pg_memory_is_all_zeros() in memutils.h
- 07e9e28b56db 18.0 landed