Re: pg_rewind fails on Windows where tablespaces are used

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: Alexandra Wang <alexandra.wang.oss@gmail.com>, Chris Travers <chris.travers@stormatics.tech>, Farooq Rashed <farooq.rashed@desc.gov.ae>, pgsql-bugs@lists.postgresql.org

Date: 2024-10-28T23:17:57Z

Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix readlink() for non-PostgreSQL junction points on Windows.
- 2c4a532c96a9 13.19 landed
- f4fd5325cc87 14.16 landed
- 9b136b0f2e53 15.11 landed
Fix stat() for recursive junction points on Windows.
- fbf8efbda88c 13.19 landed
- 9f1c67488e59 14.16 landed
- e708f31881fd 15.11 landed
Fix pg_rewind with in-place tablespaces when source is remote
- bf227926d22b 17.0 cited
Make unlink() work for junction points on Windows.
- f357233c9db8 16.0 cited
Use in-place tablespaces in regression test.
- d6d317dbf615 15.0 cited

On Mon, Oct 28, 2024 at 03:00:12PM -0400, Andrew Dunstan wrote:
> Well, it seems like it's clearly a bug. I'm never happy leaving bugs
> unfixed. As for 12, what's the point of putting out one last release if it's
> not to fix bugs?

There is always a risk of breaking something that worked previously,
and we would be out of options to address these once the branch is
EOL'd.  The risk/reward ratio for v12 is really different, so I'd
advise some caution particularly with this area of the code.

> EDB's customer will probably be happy if we just fix 15, but I would rather
> take a broader view and fix it for other possible users too.
> 
> I'm traveling for a few days but it was my intention to work on these when I
> am back.

Cool.  Thanks!
--
Michael