Horton

Re: Converting contrib SQL functions to new style

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Ronan Dunklau <ronan.dunklau@aiven.io>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Date: 2024-11-07T01:06:37Z
Lists: pgsql-hackers 
On Wed, Nov 06, 2024 at 10:51:29AM +0100, Ronan Dunklau wrote:
> For most of them I agree, but one side effect of the current implementation is 
> that we have a bug when pg_upgrad'ing if earthdistance is installed: 
> https://www.postgresql.org/message-id/flat/
> 152106914669.1223.5104148605998271987%40wrigleys.postgresql.org
> 
> The new version of earthdistance fixes that problem, so this one would be worth 
> a back patch to 16, giving users the opportunity to update earthdistance 
> before running pg_upgrade.

Good point.  Checking all these contrib updates one-by-one is an ant's
work, but I'll see if I can get at least some of them done on HEAD.

> Thanks for the tip about the CI, will make sure to have it setup before next 
> time.

See also "Enabling cirrus-ci in a github repository" in
src/tools/ci/README.
--
Michael

Commits

  1. Use @extschema:name@ notation in contrib transform modules.

  2. pg_freespacemap: Fix declaration of pg_freespace(regclass)

  3. contrib/pageinspect: Use SQL-standard function bodies.

  4. contrib/xml2: Use SQL-standard function bodies.

  5. contrib/citext: Use SQL-standard function bodies.

  6. contrib/earthdistance: Use SQL-standard function bodies.

  7. contrib/lo: Use SQL-standard function bodies

  8. xml2: Add tests for functions xpath_nodeset() and xpath_list()

  9. contrib/lo: Add test for function lo_oid()

  10. pg_freespacemap: Use SQL-standard function bodies

  11. Add @extschema:name@ and no_relocate options to extensions.

  12. Make contrib modules' installation scripts more secure.