Re: Fix port/pg_iovec.h building extensions on x86_64-darwin

Nathan Bossart <nathandbossart@gmail.com>

From: Nathan Bossart <nathandbossart@gmail.com>

To: Thomas Munro <thomas.munro@gmail.com>

Cc: Wolfgang Walther <walther@technowledgy.de>, pgsql-hackers@lists.postgresql.org

Date: 2024-11-08T22:36:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix sign-compare warnings in pg_iovec.h.
- 0fa688406595 18.0 landed
- 0a883a067bd7 17.1 landed

On Sat, Nov 09, 2024 at 11:26:44AM +1300, Thomas Munro wrote:
> Out of curiosity, is nixos deliberately using an old macOS deployment
> target or SDK, 10.something?  I'm just wondering if our feature
> detection is working correctly on macOS/x86, because I'd expect real
> preadv/pwritev to be there from 11 onwards, and 11 is already out of
> support by Apple.

It appears to be working for longfin [0].

[0] https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=longfin&dt=2024-11-08%2021%3A36%3A02&stg=configure

-- 
nathan