Horton

Re: Use more CppAsString2() in pg_amcheck.c

Nathan Bossart <nathandbossart@gmail.com>

View thread View on postgr.es
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-10-18T17:22:26Z
Lists: pgsql-hackers 
On Fri, Oct 18, 2024 at 06:50:50PM +0900, Michael Paquier wrote:
> -	appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != 't'");
> +	appendPQExpBufferStr(&sql, "\nWHERE c.relpersistence != "
> +						 CppAsString2(RELPERSISTENCE_TEMP) " ");

I think these whitespace changes may cause invalid statements to be
produced in some code paths.  IMHO those should be reserved for a separate
patch, anyway.

-- 
nathan

Commits

  1. pg_amcheck: Use CppAsString2() for relkind and relpersistence in queries