Missing deconstruct_array_builtin usage
Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Date: 2024-10-11T05:37:07Z
Lists: pgsql-hackers
Attachments
- v1-0001-Missing-deconstruct_array_builtin-usage.patch (text/x-diff)
Hi hackers, While working on [1], I noticed that we missed using deconstruct_array_builtin() in 062a8444242. Indeed, d746021de1 added construct_array_builtin and deconstruct_array_builtin but , later on, 062a8444242 made use of deconstruct_array for TEXTOID. Please find attached a tiny patch to add the $SUBJECT. That does not fix any issues, it just removes this unnecessary hardcoded parameters related to TEXTOID passed to deconstruct_array. A quick check: $ git grep construct_array | grep OID | grep -v builtin src/backend/catalog/pg_publication.c: deconstruct_array(arr, TEXTOID, -1, false, TYPALIGN_INT, src/backend/utils/fmgr/funcapi.c: * For the OID and char arrays, we don't need to use deconstruct_array() shows that this is the "only" miss since d746021de1, so I still don't think it has to be more "complicated" than it is currently (as already mentioned by Peter in [2]). [1]: https://www.postgresql.org/message-id/ZwdK1UYdLn/zFMHy%40ip-10-97-1-34.eu-west-3.compute.internal [2]: https://www.postgresql.org/message-id/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com Looking forward to your feedback, Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
Commits
-
Use construct_array_builtin for FLOAT8OID instead of construct_array.
- 4681ad4b2fb0 18.0 landed
-
Use deconstruct_array_builtin instead of deconstruct_array
- 099c572d3384 18.0 landed