Horton

Re: Add contrib/pg_logicalsnapinspect

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, shveta malik <shveta.malik@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-10-10T13:10:53Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix indentation issue

  2. pg_logicalinspect: Stabilize isolation tests.

  3. Add contrib/pg_logicalinspect.

  4. Move SnapBuild and SnapBuildOnDisk structs to snapshot_internal.h.

Attachments

Hi,

On Thu, Oct 10, 2024 at 12:05:10AM -0700, Masahiko Sawada wrote:
> On Wed, Oct 9, 2024 at 8:32 PM Bertrand Drouvot
> <bertranddrouvot.pg@gmail.com> wrote:
> > So I think that having construct_array_builtin()/deconstruct_array_builtin()
> > taking care of XIDOID is the way to go. If that makes sense to you then I'll
> > submit a dedicated patch for it, thoughts?
> 
> Your explanation makes sense to me.

Thanks for sharing your thoughts.

> I think it can be included in the main pg_logicalinspect patch as this change
> is a part of it.

Okay, let's keep the discussion here. Please find attached v13 that takes care
of your previous remarks and Peter's one ([1]).

FYI, v13 is splitted into 2 sub-patches (0001 for the discussion related to
XIDOID and construct_array_builtin() and 0002 for the module itself).

FWIW, the elmbyval and elmalign values that are added in 0001 have been deduced
 from:

postgres=# select typbyval, typalign from pg_type where typname = 'xid';
 typbyval | typalign
----------+----------
 t        | i
(1 row)


[1]: https://www.postgresql.org/message-id/ZwY5vBI%2BR8Ky7yM5%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com