Re: pgsql: Implement pg_wal_replay_wait() stored procedure

Michael Paquier <michael@paquier.xyz>

From: Michael Paquier <michael@paquier.xyz>

To: Alexander Korotkov <aekorotkov@gmail.com>

Cc: Peter Eisentraut <peter@eisentraut.org>, Alexander Korotkov <akorotkov@postgresql.org>, pgsql-committers@lists.postgresql.org

Date: 2024-09-27T04:57:23Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Revert pg_wal_replay_wait() stored procedure
- 3a7ae6b3d91e 18.0 landed
Add 'no_error' argument to pg_wal_replay_wait()
- e546989a269d 18.0 landed
Refactor WaitForLSNReplay() to return the result of waiting
- 73da6b8d1b3e 18.0 landed
Make WaitForLSNReplay() issue FATAL on postmaster death
- 6cfebfe88b9a 18.0 landed
Move LSN waiting declarations and definitions to better place
- 5035172e4ab5 18.0 landed
Update oid for pg_wal_replay_wait() procedure
- e658038772f5 18.0 landed
Move pg_wal_replay_wait() to xlogfuncs.c
- 014f9f34d252 18.0 landed
Implement pg_wal_replay_wait() stored procedure
- 3c5db1d6b016 18.0 cited

On Fri, Sep 27, 2024 at 01:35:23PM +0900, Michael Paquier wrote:
> I would suggest to keep things simple and have one single function
> rather than introduce two more pg_proc entries with slight differences
> in their error reporting, making the original function return a text
> about the reason of the failure when waiting (be it a timeout,
> success, promotion or outside recovery).

More to the point here.  I am not sure what's the benefit of having a
procedure, while we have been using SQL functions for similar purposes
in xlogfuncs.c for years.  And what you have here can also be coupled
with more complex logic in SQL queries.
--
Michael