Horton

Re: Add contrib/pg_logicalsnapinspect

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2024-09-25T17:31:14Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix indentation issue

  2. pg_logicalinspect: Stabilize isolation tests.

  3. Add contrib/pg_logicalinspect.

  4. Move SnapBuild and SnapBuildOnDisk structs to snapshot_internal.h.

Hi,

On Wed, Sep 25, 2024 at 11:23:17AM +0530, shveta malik wrote:
> + OUT catchange_xip xid[]
> 
> One question, what is xid datatype, is it too int8? Sorry, could not
> find the correct doc.

I think that we can get the answer from pg_type:

postgres=# select typname,typlen from pg_type where typname = 'xid';
 typname | typlen
---------+--------
 xid     |      4
(1 row)

> Since we are getting uint32 in Int64, this also needs to be accordingly.

I think the way it is currently done is fine: we're dealing with TransactionId
(and not with FullTransactionId). So, the Int64GetDatum() output would still
stay in the "xid" range. Keeping xid in the .sql makes it clear that we are
dealing with transaction ID.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com