Horton

Thread

Commits

  1. doc: Clarify name of files generated by pg_waldump --save-fullpage

  1. Patch: Make pg_waldump.sgml less confusing

    Christoph Berg <myon@debian.org> — 2024-10-01T21:44:40Z

    The pg_waldump manpage says the --save-fullpage output format was

  TIMELINE-LSN.RELTABLESPACE.DATOID.RELNODE.BLKNOFORK

when the filenames actually have the format

  00000001-00000000-309A88C0.1663.5.64080.0_main

with an underscore in front of FORK.

While that is technically correct because it then explains that
FORK is something like "_main", I think this is just confusing and
moving the underscore into the file name format description is much
cleaner. (And inside the rest of the code, the fork names don't have
underscore prefixes either.)

Christoph

  2. Re: Patch: Make pg_waldump.sgml less confusing

    Michael Paquier <michael@paquier.xyz> — 2024-10-01T22:51:06Z

    On Tue, Oct 01, 2024 at 11:44:40PM +0200, Christoph Berg wrote:
> While that is technically correct because it then explains that
> FORK is something like "_main", I think this is just confusing and
> moving the underscore into the file name format description is much
> cleaner. (And inside the rest of the code, the fork names don't have
> underscore prefixes either.)

Good point.  What you are proposing is easier to read.  Will fix.
Thanks for the report.
--
Michael