Re: Exporting float_to_shortest_decimal_buf(n) with Postgres 17 on Windows
Nathan Bossart <nathandbossart@gmail.com>
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Kane <andrew@ankane.org>, pgsql-hackers@postgresql.org
Date: 2024-09-13T21:41:23Z
Lists: pgsql-hackers
On Fri, Sep 13, 2024 at 04:58:20PM -0400, Tom Lane wrote: > Andrew Kane <andrew@ankane.org> writes: >> With Postgres 17 RC1 on Windows, `float_to_shortest_decimal_buf` and >> `float_to_shortest_decimal_bufn` are not longer exported. This causes >> `unresolved external symbol` linking errors for extensions that rely on >> these functions (like pgvector). Can these functions be exported like >> previous versions of Postgres? > > AFAICS it's in the exact same place it was in earlier versions. > You might need to review your linking commands. I do see a fair amount of special handling for f2s.c in the build files. I wonder if something got broken for Windows in the switch from the MSVC scripts to meson. -- nathan
Commits
-
meson: Export all libcommon functions in Windows builds
- 643efb18bf80 16.7 landed
- d8b0c6411648 17.3 landed
- 07f902bd7607 18.0 landed
- 4e0d71ff2259 16.7 landed
- c80acbc6fae8 17.3 landed
- 2571c1d5cc5e 18.0 landed