Horton

Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Ayush Vatsa <ayushvatsa1810@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-09-13T00:47:36Z
Lists: pgsql-hackers 
On Thu, Sep 12, 2024 at 07:41:30PM -0500, Nathan Bossart wrote:
> On Thu, Sep 12, 2024 at 04:39:14PM -0500, Nathan Bossart wrote:
> > Committed.
> 
> Ugh, the buildfarm is unhappy with the new tests [0] [1].  Will fix.

I'd suggest to switch the test to return a count() and make sure that
one record exists.  The data in the page does not really matter.
--
Michael

Commits

  1. Fix contrib/pageinspect's test for sequences.

  2. Reintroduce support for sequences in pgstattuple and pageinspect.

  3. Only allow heap in a number of contrib modules.