Horton

Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch

Michael Paquier <michael@paquier.xyz>

View thread View on postgr.es
From: Michael Paquier <michael@paquier.xyz>
To: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Ayush Vatsa <ayushvatsa1810@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-09-12T02:19:00Z
Lists: pgsql-hackers 
On Wed, Sep 11, 2024 at 11:02:43PM +0100, Matthias van de Meent wrote:
> On Wed, 11 Sept 2024 at 21:36, Nathan Bossart <nathandbossart@gmail.com> wrote:
> >
> > Barring objections, I'm planning to commit v3 soon.  Robert/Matthias, I'm
> > not sure you are convinced this is the right thing to do (or worth doing,
> > rather), but I don't sense that you are actually opposed to it, either.
> > Please correct me if I am wrong.
> 
> Correct: I do think making heapam-related inspection functions have a
> consistent behaviour when applied to sequences is beneficial, with no
> preference towards specifically supporting or not supporting sequences
> in these functions. If people that work on sequences think it's better
> to also support inspection of sequences, then I think that's a good
> reason to add that support where it doesn't already exist.
> 
> As for patch v3, that seems fine with me.

+1 from here as well, after looking at what v3 is doing for these two
modules.
--
Michael

Commits

  1. Fix contrib/pageinspect's test for sequences.

  2. Reintroduce support for sequences in pgstattuple and pageinspect.

  3. Only allow heap in a number of contrib modules.